From ebe30a8fc063c0ef51b79304f63714f5fcd73f2b Mon Sep 17 00:00:00 2001
From: Stephan Heunis <s.heunis@fz-juelich.de>
Date: Sun, 1 Oct 2023 21:41:39 +0200
Subject: [PATCH 1/3] Fix subdataset filtering to filter on name, givenName,
 and familyName, provided that the property value in each case is not null

---
 .../catalog/assets/app_component_dataset.js           | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/datalad_catalog/catalog/assets/app_component_dataset.js b/datalad_catalog/catalog/assets/app_component_dataset.js
index 572fb49f..e7542893 100644
--- a/datalad_catalog/catalog/assets/app_component_dataset.js
+++ b/datalad_catalog/catalog/assets/app_component_dataset.js
@@ -218,10 +218,17 @@ const datasetView = () =>
                 c.dirs_from_path[c.dirs_from_path.length - 1]
                   .toLowerCase()
                   .indexOf(this.search_text.toLowerCase()) >= 0 ||
-                // || (c.authors.some(e => e.givenName.toLowerCase().indexOf(this.search_text.toLowerCase()) >= 0))
                 c.authors.some(
                   (f) =>
-                    f.name.toLowerCase().indexOf(this.search_text.toLowerCase()) >= 0
+                  f.givenName && f.givenName.toLowerCase().indexOf(this.search_text.toLowerCase()) >= 0 
+                ) ||
+                c.authors.some(
+                  (f) =>
+                  f.familyName && f.familyName.toLowerCase().indexOf(this.search_text.toLowerCase()) >= 0 
+                ) ||
+                c.authors.some(
+                  (f) =>
+                  f.name && f.name.toLowerCase().indexOf(this.search_text.toLowerCase()) >= 0
                 )
               );
             });

From 11418a1629e5b3a77124a26bdeb8bce749fabf20 Mon Sep 17 00:00:00 2001
From: Stephan Heunis <s.heunis@fz-juelich.de>
Date: Sun, 1 Oct 2023 23:54:06 +0200
Subject: [PATCH 2/3] only show filtering options when number of subdatasets >
 3

This will hide the filtering options otherwise. Additionally, the tags
on each subdataset will be deactivated if number of subdatasets < 4.
---
 datalad_catalog/catalog/templates/dataset-template.html | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/datalad_catalog/catalog/templates/dataset-template.html b/datalad_catalog/catalog/templates/dataset-template.html
index c80db10a..930762ee 100644
--- a/datalad_catalog/catalog/templates/dataset-template.html
+++ b/datalad_catalog/catalog/templates/dataset-template.html
@@ -170,7 +170,7 @@ <h3>Cite dataset</h3>
             <span v-else>
               <span v-if="!subdatasets || !subdatasets.length"><em>There are no subdatasets listed for the current dataset</em></span>
               <span v-else>
-                <b-form>
+                <b-form v-if="subdatasets.length > 3">
                   <b-row>
                     <b-col md="7">
                       <b-input-group>
@@ -246,7 +246,12 @@ <h5><a @click="selectDataset($event, ds)" class="newlink">{{ds.dirs_from_path.at
                       </b-col>
                       <b-col md="4">
                         <b-card-text>
-                          <span v-for="keyword in ds.keywords"><b-button pill size="sm" class="p-1" variant="outline-dark" @click="addSearchTag(keyword)">{{keyword}}</b-button>&nbsp;</span>
+                          <span v-if="subdatasets.length > 3">
+                            <span v-for="keyword in ds.keywords"><b-button pill size="sm" class="p-1" variant="outline-dark" @click="addSearchTag(keyword)">{{keyword}}</b-button>&nbsp;</span>
+                          </span>
+                          <span v-else>
+                            <span v-for="keyword in ds.keywords"><b-button pill size="sm" class="p-1" variant="outline-secondary">{{keyword}}</b-button>&nbsp;</span>
+                          </span>
                         </b-card-text>
                       </b-col>
                     </b-row>

From d8090c66ea67d08887fed685f2fd70ea2c290503 Mon Sep 17 00:00:00 2001
From: Stephan Heunis <s.heunis@fz-juelich.de>
Date: Sun, 1 Oct 2023 23:59:25 +0200
Subject: [PATCH 3/3] Clear filtering options when navigating to a subdataset

This is to prevent the filtering options from remaining and subsequently
filtering the subdatasets of the recently selected dataset (after filtering).
---
 datalad_catalog/catalog/assets/app_component_dataset.js | 8 ++++++++
 datalad_catalog/catalog/assets/app_component_item.js    | 3 +++
 datalad_catalog/catalog/templates/dataset-template.html | 2 +-
 datalad_catalog/catalog/templates/item-template.html    | 2 +-
 4 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/datalad_catalog/catalog/assets/app_component_dataset.js b/datalad_catalog/catalog/assets/app_component_dataset.js
index e7542893..c3073e6e 100644
--- a/datalad_catalog/catalog/assets/app_component_dataset.js
+++ b/datalad_catalog/catalog/assets/app_component_dataset.js
@@ -333,6 +333,9 @@ const datasetView = () =>
                   dataset_version: objVersion,
                 },
               }
+              // before navigation, clear filtering options
+              this.clearFilters()
+              // now navigate
               if (newBrowserTab) {
                 const routeData = router.resolve(route_info);
                 window.open(routeData.href, '_blank');
@@ -345,6 +348,11 @@ const datasetView = () =>
               this.$root.$emit("bv::show::modal", "modal-3", "#btnShow");
             }
           },
+          clearFilters() {
+            this.search_text = ""
+            this.search_tags = []
+            this.clearSearchTagText()
+          },
           selectDescription(desc) {
             if (desc.content.startsWith("path:")) {
               this.description_ready = false;
diff --git a/datalad_catalog/catalog/assets/app_component_item.js b/datalad_catalog/catalog/assets/app_component_item.js
index bfe0a4c8..dea66b53 100644
--- a/datalad_catalog/catalog/assets/app_component_item.js
+++ b/datalad_catalog/catalog/assets/app_component_item.js
@@ -89,6 +89,9 @@ Vue.component('tree-item', function (resolve, reject) {
                       dataset_version: objVersion,
                     },
                   }
+                  // before navigation, clear filter options
+                  this.$emit('clear-filters')
+                  // now navigate
                   if (newBrowserTab) {
                     const routeData = router.resolve(route_info);
                     window.open(routeData.href, '_blank');
diff --git a/datalad_catalog/catalog/templates/dataset-template.html b/datalad_catalog/catalog/templates/dataset-template.html
index 930762ee..48d43f23 100644
--- a/datalad_catalog/catalog/templates/dataset-template.html
+++ b/datalad_catalog/catalog/templates/dataset-template.html
@@ -270,7 +270,7 @@ <h5><a @click="selectDataset($event, ds)" class="newlink">{{ds.dirs_from_path.at
               <span v-else>
                 <b-card no-body class="p-2">
                   <ul>
-                    <tree-item class="item" v-for="item in selectedDataset.tree" :item="item"></tree-item>
+                    <tree-item class="item" v-for="item in selectedDataset.tree" :item="item" @clear-filters="clearFilters"></tree-item>
                   </ul>
                 </b-card>
               </span>
diff --git a/datalad_catalog/catalog/templates/item-template.html b/datalad_catalog/catalog/templates/item-template.html
index 20bea14e..24de4015 100644
--- a/datalad_catalog/catalog/templates/item-template.html
+++ b/datalad_catalog/catalog/templates/item-template.html
@@ -17,6 +17,6 @@
     </div>
     <!-- Children of an open folder -->
     <ul v-show="isOpen" v-if="isFolder">
-        <tree-item class="item" v-for="(child, index) in item.children" :key="index" :index="index" :item="child"></tree-item>
+        <tree-item class="item" v-for="(child, index) in item.children" :key="index" :index="index" :item="child" v-on="$listeners"></tree-item>
     </ul>
 </li>
\ No newline at end of file