Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority inversion when using '@' to load from file #8

Open
ebekebe opened this issue Nov 17, 2017 · 0 comments
Open

Priority inversion when using '@' to load from file #8

ebekebe opened this issue Nov 17, 2017 · 0 comments
Labels

Comments

@ebekebe
Copy link
Collaborator

ebekebe commented Nov 17, 2017

Consider:

config
      .loadDefaultFiles()
      .loadCliArguments()

The intention is to let CLI arguments override the settings from the default files. However, this logic can be inverted in the following way:

  • a default file include the key @someEntry: /path/to/file/with/content and
  • a cli argument --someEntry what-should-be-used is passed

The result should be that in the final config, someEntry should contain what should be used. The current behavior is that it contains the contents of /path/to/file/with/content

@ebekebe ebekebe added the bug label Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant