We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RedisResult[List[(K, V)]]
Looks like https://github.com/davenverse/rediculous/blob/main/core/shared/src/main/scala/io/chrisdavenport/rediculous/RedisResult.scala#L125-L144 isn't stack safe and can fail for large lists (this happened to me).
The text was updated successfully, but these errors were encountered:
Yeah, here's the recursive call to pairs in a non-tail position.
pairs
rediculous/core/shared/src/main/scala/io/chrisdavenport/rediculous/RedisResult.scala
Lines 134 to 135 in 0d0c2d6
Since this is Either this may have to be rewritten with tailRecM from Cats 🤔
Either
tailRecM
Or on second thought, if tailRecM is possible it should be possible to just manually write a tail recursive function.
Sorry, something went wrong.
I think I have something working in terms of tailRecM: https://github.com/buntec/rediculous/blob/fix/pub-sub/core/shared/src/main/scala/io/chrisdavenport/rediculous/RedisResult.scala#L129-L140
Successfully merging a pull request may close this issue.
Looks like https://github.com/davenverse/rediculous/blob/main/core/shared/src/main/scala/io/chrisdavenport/rediculous/RedisResult.scala#L125-L144 isn't stack safe and can fail for large lists (this happened to me).
The text was updated successfully, but these errors were encountered: