Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout Backoff Multiplier #32

Open
ryanburr opened this issue Mar 9, 2016 · 4 comments
Open

Timeout Backoff Multiplier #32

ryanburr opened this issue Mar 9, 2016 · 4 comments

Comments

@ryanburr
Copy link

ryanburr commented Mar 9, 2016

I noticed that this library will try and reconnect indefinitely. My thought is that it would be nice to have a mechanisms to control how/when the service tries to reconnect, so I am suggesting this.

A timeout backoff multiplier + maximum timeout setting. This will increment the timeout value by the multiplier every time the service tries to reconnect. If it exceeds the maximum, it will use that. If it reconnects, it will default back to the original timeout for next time.

Thoughts?

@davinkevin
Copy link
Owner

Really interesting.

It will be a real improvement. If some of you want to do a Pull Request about that, it will be welcomed.

Thanks for the proposal.

@davinkevin
Copy link
Owner

davinkevin commented Apr 16, 2016

We also can use the timeout and rely on the HTML5 API to know if the browser is offline to prevent any request :

@GatoSnake
Copy link

GatoSnake commented May 9, 2017

what is the status of this issue?

@davinkevin
Copy link
Owner

I haven't implemented and don't have time to do it 😢 , but PR are welcome, so don't hesitate...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants