Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'text-formatter' sample project to index.json #1575

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

Mohiit70
Copy link
Contributor

Added sample project to index.json

Pull Request Title

Description

Please include a summary of the change or the feature being introduced. Include relevant motivation and context. List any dependencies that are required for this change.

  • This change requires a documentation update
  • I have made corresponding changes to the documentation

Related Issue(s)

This PR addresses issue #X

Screenshots

If relevant, please add screenshots.

Notes

Please add any relevant notes if necessary.

@Mohiit70 Mohiit70 requested a review from a team as a code owner December 26, 2024 03:04
@RS-labhub
Copy link
Contributor

RS-labhub commented Dec 26, 2024

Sign the DCO please:

git commit --amend --author="your_name <your_email>"
example: git commit --amend --author="Rohan Sharma 117426013+RS-labhub@users.noreply.github.com"

Or do git commit --amend and then add this message below your commit message:
Signed-off-by: your-name <your-email>

The email should be one associated with your github

and then push it forcefully (git push --force)

Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign the commit

@Mohiit70 Mohiit70 force-pushed the add-sample-project-text-formatter branch from bb0c9e7 to cdd91dc Compare December 26, 2024 10:05
Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit is still not signed off.
Run "git commit --amend -s --no-edit && git push -f"

Added sample project to index.json

Signed-off-by: Mohit Bisht <mail.mohitbisht@gmail.com>
@Mohiit70 Mohiit70 force-pushed the add-sample-project-text-formatter branch from cdd91dc to b457398 Compare December 26, 2024 15:04
@Tpuljak
Copy link
Member

Tpuljak commented Dec 27, 2024

@Mohiit70 please resolve the conflict

@Mohiit70
Copy link
Contributor Author

@Mohiit70 please resolve the conflict

Done

@Tpuljak Tpuljak merged commit d370264 into daytonaio:main Dec 27, 2024
1 check passed
Jitankasarkar pushed a commit to Jitankasarkar/daytona that referenced this pull request Dec 28, 2024
Signed-off-by: Mohit Bisht <mail.mohitbisht@gmail.com>
Signed-off-by: Jitankasarkar <jitankasarkar2017@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants