Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata not passed to the writer #78

Open
eroux opened this issue Feb 20, 2020 · 2 comments
Open

metadata not passed to the writer #78

eroux opened this issue Feb 20, 2020 · 2 comments

Comments

@eroux
Copy link

eroux commented Feb 20, 2020

We recently discovered an issue on our server that's probably the same as dbmdz/iiif-server-hymir#68 , the problem is that no ICC profile of is written by imageio-jnr. In fact, looking at TurboJpegImageWriter.write, it seems all IIOMetadata is ignored when writing an image. Is there a trick to work around the problem?

@eroux
Copy link
Author

eroux commented Feb 25, 2020

In fact the main problem is not directly with IIOMetadata, it's that the ColorModel of the BufferedImage is not used by the writer. So when the writer outputs an image with a custom ICCProfile in the ColorModel, the profile is not embedded and the colors are off. See this function for an example.

@jbaiter
Copy link
Member

jbaiter commented Oct 14, 2020

ICC color profiles are currently not supported (I don't think this is currently documented, but certainly should be!), but I'd gladly accept a PR that adds support for them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants