Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warning for disabled models #10024

Closed
3 tasks done
macklin-fluehr opened this issue Apr 24, 2024 · 2 comments
Closed
3 tasks done

add warning for disabled models #10024

macklin-fluehr opened this issue Apr 24, 2024 · 2 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@macklin-fluehr
Copy link

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

if you try to directly test a disabled model, you are presented with a generic error: Nothing to do. Try checking your model configs and model specification args.'

I think it's a good feature to ignore disabled models completely when selecting multiple nodes in the dag. However, if I directly select a model, let's say for a dbt test -s my_model, I should not receive the generic error, but should receive a warning that this model is specifically disabled.

Describe alternatives you've considered

this is a 0-1 feature to me. the only workaround is pure brute-force trying to figure out if disabling the model is the reason nothing is happening

Who will this benefit?

anyone debugging code that is for some reason, has 'nothing to do'.

Are you interested in contributing this feature?

No response

Anything else?

No response

@macklin-fluehr macklin-fluehr added enhancement New feature or request triage labels Apr 24, 2024
@dbeatty10 dbeatty10 self-assigned this Apr 24, 2024
@dbeatty10
Copy link
Contributor

Thanks for opening this issue @macklin-fluehr 💡

Good news: great minds think alike and we recently merged #9863 with an update to this warning message.

I'm closing this is a duplicate of #9747, but please let us know if you think the new error message won't work for some reason.

@dbeatty10 dbeatty10 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2024
@dbeatty10 dbeatty10 added duplicate This issue or pull request already exists and removed triage labels Apr 24, 2024
@dbeatty10 dbeatty10 removed their assignment Apr 24, 2024
@macklin-fluehr
Copy link
Author

macklin-fluehr commented Apr 24, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants