Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add tests for installing local package when symlinks are not supported by the OS #10796

Open
1 task done
dbeatty10 opened this issue Sep 30, 2024 · 0 comments
Open
1 task done
Labels
enhancement New feature or request tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Sep 30, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

We are not currently testing the case where the user's operating system (OS) doesn't support symlinks. As a result, we could accidentally break these code paths in the future.

So we'd like to add functional tests for scenarios like #9719 specifically when the OS running dbt does not support symlinks.

Create a packages.yml file:

packages:
    - local: ../

Then install it:

dbt deps

Acceptance criteria

There are functional tests that cover the code paths when a user's operating system doesn't support symlinks (which is used for local package dependencies when running dbt deps).

Suggested Tests

We don't know how exactly to test it currently, so this would be something to brainstorm and choose an approach.

Impact to Other Teams

None.

Will backports be required?

It would probably be wise to backport to supported versions of dbt-core to avoid accidentally missing regressions when merging other backports!

Context

This was discovered during review of #9734.

@dbeatty10 dbeatty10 added enhancement New feature or request tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

No branches or pull requests

1 participant