From dd3164714198318136ce14f5629def2ab1aff58d Mon Sep 17 00:00:00 2001 From: Ernesto Ongaro Date: Tue, 8 Oct 2024 16:44:26 +0100 Subject: [PATCH 1/2] Clarification for incremental-microbatch.md It's not clear in the Example that we need to do some configuration on the event_time, it is only mentioned at the bottom of the page --- website/docs/docs/build/incremental-microbatch.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/website/docs/docs/build/incremental-microbatch.md b/website/docs/docs/build/incremental-microbatch.md index b4b5406127e..c6739df42c6 100644 --- a/website/docs/docs/build/incremental-microbatch.md +++ b/website/docs/docs/build/incremental-microbatch.md @@ -30,6 +30,15 @@ A `sessions` model is aggregating and enriching data that comes from two other m The `page_view_start` column in `page_views` is configured as that model's `event_time`. The `customers` model does not configure an `event_time`. Therefore, each batch of `sessions` will filter `page_views` to the equivalent time-bounded batch, and it will not filter `customers` (a full scan for every batch). + + +```yaml +models: + - name: page_views + config: + event_time: page_view_start +``` + We run the `sessions` model on October 1, 2024, and then again on October 2. It produces the following queries: From df4d3c3a7ccbdb1425aebd4ad620f03d88043d01 Mon Sep 17 00:00:00 2001 From: Mirna Wong <89008547+mirnawong1@users.noreply.github.com> Date: Tue, 8 Oct 2024 16:47:09 +0100 Subject: [PATCH 2/2] Update website/docs/docs/build/incremental-microbatch.md --- website/docs/docs/build/incremental-microbatch.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/docs/docs/build/incremental-microbatch.md b/website/docs/docs/build/incremental-microbatch.md index c6739df42c6..2bfc07d8e2e 100644 --- a/website/docs/docs/build/incremental-microbatch.md +++ b/website/docs/docs/build/incremental-microbatch.md @@ -38,7 +38,7 @@ models: config: event_time: page_view_start ``` - + We run the `sessions` model on October 1, 2024, and then again on October 2. It produces the following queries: