From b70c0dbc46bb4b1d77bee5e60c8ceb60135fc92b Mon Sep 17 00:00:00 2001 From: Charlie Hahn Date: Tue, 15 Aug 2023 09:29:42 -0400 Subject: [PATCH 1/2] Update custom-schemas.md Update grammar from "overriding" to "override" --- website/docs/docs/build/custom-schemas.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/docs/docs/build/custom-schemas.md b/website/docs/docs/build/custom-schemas.md index b8dbb9a0846..b5f29ce76a2 100644 --- a/website/docs/docs/build/custom-schemas.md +++ b/website/docs/docs/build/custom-schemas.md @@ -103,7 +103,7 @@ To modify how dbt generates schema names, you should add a macro named `generate If you're modifying how dbt generates schema names, don't just replace ```{{ default_schema }}_{{ custom_schema_name | trim }}``` with ```{{ custom_schema_name | trim }}``` in the ```generate_schema_name``` macro. -Removing ```{{ default_schema }}``` causes developers to overriding each other's models when custom schemas are defined. This can also cause issues during development and continuous integration (CI). +Removing ```{{ default_schema }}``` causes developers to override each other's models when custom schemas are defined. This can also cause issues during development and continuous integration (CI). ❌ The following code block is an example of what your code _should not_ look like: ```sql From 4dded1de6ef92b32df019eacda605ea79b5b0e2c Mon Sep 17 00:00:00 2001 From: mirnawong1 <89008547+mirnawong1@users.noreply.github.com> Date: Tue, 15 Aug 2023 09:40:36 -0400 Subject: [PATCH 2/2] Update website/docs/docs/build/custom-schemas.md --- website/docs/docs/build/custom-schemas.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/docs/docs/build/custom-schemas.md b/website/docs/docs/build/custom-schemas.md index b5f29ce76a2..d8a319f40de 100644 --- a/website/docs/docs/build/custom-schemas.md +++ b/website/docs/docs/build/custom-schemas.md @@ -103,7 +103,7 @@ To modify how dbt generates schema names, you should add a macro named `generate If you're modifying how dbt generates schema names, don't just replace ```{{ default_schema }}_{{ custom_schema_name | trim }}``` with ```{{ custom_schema_name | trim }}``` in the ```generate_schema_name``` macro. -Removing ```{{ default_schema }}``` causes developers to override each other's models when custom schemas are defined. This can also cause issues during development and continuous integration (CI). +If you remove ```{{ default_schema }}```, it causes developers to override each other's models if they create their own custom schemas. This can also cause issues during development and continuous integration (CI). ❌ The following code block is an example of what your code _should not_ look like: ```sql