Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add UI distinction to tell tabs are tabs #3889

Open
1 task done
alison985 opened this issue Aug 8, 2023 · 3 comments
Open
1 task done

Suggestion: Add UI distinction to tell tabs are tabs #3889

alison985 opened this issue Aug 8, 2023 · 3 comments
Labels
engineering improvement that requires site engineering help or back up priority: medium Fix or enhancement to existing information that’s creating some requests from customers

Comments

@alison985
Copy link
Contributor

Contributions

  • I have read the contribution docs, and understand what's expected of me.

What page(s) or areas on docs.getdbt.com are affected?

https://docs.getdbt.com/reference/resource-configs/meta#designate-a-source-column-as-containing-pii is an easy example page because it contains an example at the top of the page that has a lot of "tab" options.

Screenshot 2023-08-08 at 10 33 28 AM

This is in Chrome on Mac Ventura.

What changes are you suggesting?

As a first time user it's hard to tell that Models, Sources, Seeds, etc. are tabs and that I should click on the tab to see a specific implementation. As I've continued to use the docs over time I still miss that there are other tabs I could refer to. I think adding some kind of box around the title of each tab would help visually identify that those words indicate tabs and that you should click on them.

Additional information

No response

@alison985 alison985 added the engineering improvement that requires site engineering help or back up label Aug 8, 2023
@mirnawong1
Copy link
Contributor

hey @alison985 thanks so much for opening this issue up and i can absolutely see this as well! i appreciate you adding detail and this is something we can def look at in the future and make clearer. thanks again!

@mirnawong1
Copy link
Contributor

Looks like we can customize tabs to make them clearer to users

@runleonarun
Copy link
Collaborator

runleonarun commented Aug 11, 2023

I love this idea! I was just thinking about this when I reviewed a PR. @mirnawong1 thanks for doing that research! We should create an asana task the front-en eng team.

@runleonarun runleonarun added the priority: medium Fix or enhancement to existing information that’s creating some requests from customers label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering improvement that requires site engineering help or back up priority: medium Fix or enhancement to existing information that’s creating some requests from customers
Projects
None yet
Development

No branches or pull requests

3 participants