Add per-measure validation in query validation rules #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serramatutu
reviewed
Oct 28, 2024
| @@ -65,7 +65,18 @@ def _default_handler(self, node: GroupByItemResolutionNode) -> MetricFlowQueryRe | |||
|
|
|||
| @override | |||
| def visit_measure_node(self, node: MeasureGroupByItemSourceNode) -> MetricFlowQueryResolutionIssueSet: | |||
| return self._default_handler(node) | |||
| with self._path_from_start_node_tracker.track_node_visit(node) as current_traversal_path: | |||
There was a problem hiding this comment.
Just curious: what is this track_node_visit for? Just for our own debugging?
There was a problem hiding this comment.
It's both for debugging and providing context to validation error messages.
serramatutu
approved these changes
Oct 28, 2024
Base automatically changed from
p--short-term-perf--26
to
p--short-term-perf--25
October 29, 2024 22:55
plypaul
force-pushed
the
p--short-term-perf--27
branch
from
5a5c7fa
to
29b6a6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the signature of the
PostResolutionQueryValidationRuleto allow for query validation on a per-measure basis. This allows for simpler validation for checks that depend on a measure as used in a later PR.