Add MeasureLookup to break-up SemanticModelLookup
#1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plypaul
changed the title
MeasureLookupMeasureLookup to break-up SemanticModelLookup
plypaul
force-pushed
the
p--short-term-perf--30
branch
from
d712d71
to
3fc7777
Compare
plypaul
force-pushed
the
p--short-term-perf--31
branch
from
76b36c0
to
7f06a93
Compare
WilliamDee
approved these changes
Oct 31, 2024
plypaul
force-pushed
the
p--short-term-perf--30
branch
from
3fc7777
to
6b14dbd
Compare
plypaul
force-pushed
the
p--short-term-perf--31
branch
from
7f06a93
to
6099e3b
Compare
plypaul
added a commit
that referenced
this pull request
Nov 1, 2024
Similar to #1486, this PR creates a lookup class for dimensions. This also replaces calls to the broken `get_dimension()` method, which will be removed in a later PR.
Merged
plypaul
added a commit
that referenced
this pull request
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help break up
SemanticModelLookup, this PR moves measure-related lookup methods to the separate classMeasureLookup. Note that there are additional methods to move later.