Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: Generate correct instances for JoinOnEntitiesNode #1499

Merged
merged 10 commits into from
Nov 5, 2024
Merged

Bug fix: Generate correct instances for JoinOnEntitiesNode #1499

merged 10 commits into from
Nov 5, 2024

Commits on Nov 2, 2024

  1. Add some new make commands to simplify testing

    @courtneyholcomb
    courtneyholcomb committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    7867817 View commit details
    Browse the repository at this point in the history

  2. Add detail to error messages for debugging

    @courtneyholcomb
    courtneyholcomb committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    301e697 View commit details
    Browse the repository at this point in the history

  3. Add group_instances_by_type() helper 

    This follows the exact same pattern as the existing group_specs_by_type() helper, but for instances.
    @courtneyholcomb
    courtneyholcomb committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    7dddbc2 View commit details
    Browse the repository at this point in the history

  4. Add with_entity_prefix() helpers to LinkableSpecs

    @courtneyholcomb
    courtneyholcomb committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    ba9ecf5 View commit details
    Browse the repository at this point in the history

  5. Add LinkableInstance subclass with with_entity_links() helper

    @courtneyholcomb
    courtneyholcomb committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    194c3c4 View commit details
    Browse the repository at this point in the history

  6. Bug fix: Generate correct columns for JoinOnEntitiesNode 

    Also general cleanup / simplification for this node's dataflow to SQL logic.
    @courtneyholcomb
    courtneyholcomb committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    db7f4cf View commit details
    Browse the repository at this point in the history

  7. Update DuckDB snapshots

    @courtneyholcomb
    courtneyholcomb committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    3b8ac02 View commit details
    Browse the repository at this point in the history

  8. Update snapshots for other SQL engines

    @courtneyholcomb
    courtneyholcomb committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    7e3c1c9 View commit details
    Browse the repository at this point in the history

  9. Rename function to help avoid future bugs like this

    @courtneyholcomb
    courtneyholcomb committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    ab38128 View commit details
    Browse the repository at this point in the history

  10. Clean up FilterLinkableInstancesWithLeadingLink logic

    @courtneyholcomb
    courtneyholcomb committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    acb0295 View commit details
    Browse the repository at this point in the history