Replace is_table with as_sql_table_node
#1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plypaul
commented
Nov 4, 2024
| @@ -356,11 +358,11 @@ def render_node(self) -> SqlQueryPlanNode: # noqa: D102 | |||
| class SqlCteNode(SqlQueryPlanNode): | |||
| """Represents a single common table expression.""" | |||
|
|
|||
| select_statement: SqlSelectStatementNode | |||
| select_statement: SqlQueryPlanNode | |||
There was a problem hiding this comment.
Notice this change got mixed in - this is to make recursive handling easier and it turns out the typed form is not necessary.
courtneyholcomb
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
SqlQueryPlanNode.is_tableand replaces it with a typed accessor for parallelism withas_select_node. This is helpful in handling some use cases for CTEs.