Fix bug with MetricFlowQueryRequest.sql_optimization_level handling
#1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plypaul
changed the title
MetricFlowQueryRequest.sql_optimization_level handling.MetricFlowQueryRequest.sql_optimization_level handling
courtneyholcomb
approved these changes
Nov 13, 2024
| def test_sql_optimization_level(it_helpers: IntegrationTestHelpers) -> None: | ||
| """Check that different SQL optimization levels produce different SQL.""" | ||
| assert ( | ||
| SqlQueryOptimizationLevel.default_level() != SqlQueryOptimizationLevel.O0 |
There was a problem hiding this comment.
Not a blocker for this PR, but I'm curious - do you know why the 00 enum option uses two different 0 characters? I've never seen that before!
There was a problem hiding this comment.
Borrows from the syntax from gcc: https://www.rapidtables.com/code/linux/gcc/gcc-o.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetricFlowQueryRequesthas thesql_optimization_levelfield which is supposed to control the SQL optimization level. However, it was not getting handled correctly, so this PR fixes that issue.