Update default SQL optimization level to use CTEs #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
approved these changes
Nov 13, 2024
| @@ -129,7 +129,7 @@ def create_with_random_request_id( # noqa: D102 | |||
| where_constraints: Optional[Sequence[str]] = None, | |||
| order_by_names: Optional[Sequence[str]] = None, | |||
| order_by: Optional[Sequence[OrderByQueryParameter]] = None, | |||
| sql_optimization_level: SqlQueryOptimizationLevel = SqlQueryOptimizationLevel.O4, | |||
| sql_optimization_level: SqlQueryOptimizationLevel = SqlQueryOptimizationLevel.default_level(), | |||
There was a problem hiding this comment.
You might need to check if MFS is overriding this param. I know at some point we overrode the dataflow_plan_optimizations param at least (to disable predicate pushdown) but not sure now.
| , 1 AS bookings | ||
| FROM ***************************.fct_bookings bookings_source_src_28000 | ||
| ) subq_12 | ||
| FROM rss_28020_cte rss_28020_cte |
There was a problem hiding this comment.
Noticing this alias is unnecessary duplication. Same with line 44 below. Is that intended? Maybe it's required for certain engines?
There was a problem hiding this comment.
We always specify an alias for the sources in a SELECT. This is something that can be updated, but we haven't gotten around to it. We also always specify an alias for each of the columns, which is something that can be cleaned up as well.
| @@ -0,0 +1,6 @@ | |||
| kind: Features | |||
| body: se CTEs instead of sub queries in generated SQL | |||
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1040
This PR updates the default SQL optimization level to use CTEs. This creates a number of snapshot changes as queries in tests now use CTEs in cases where there are common sources or common metrics in multi-metric / derived metric cases.