Re-categorize TypeErrors that arise from create_from_where_filter into InvalidQueryException
#817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevonFulcher
force-pushed
the
catch_sandbox_type_error
branch
from
8c11c58
to
7efde68
Compare
tlento
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://dbt-labs.slack.com/archives/C04TRSFQN75/p1697568904350429 (internal to dbt Labs)
Description
The intent of this PR is to re-categorize
TypeErrorsthat arise fromcreate_from_where_filterintoInvalidQueryException. That way, these errors can be caught and handled properly. Additionally, I move the try-catch block forParseWhereFilterExceptionto be within the body ofcreate_from_where_erthat way all call sites can benefit from that catch.