Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sql-engine-test workflow to remove label on completion. #827

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Update sql-engine-test workflow to remove label on completion. #827

merged 1 commit into from
Oct 30, 2023

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Oct 30, 2023 •
edited
Loading

Description

Currently, when iterating on a PR, the PR author would need to remove and then re-add the label to rerun the SQL-engine tests. This PR updates the Github Action workflow to remove the label for running the SQL engine tests after the tests are complete.

@cla-bot cla-bot bot added the cla:yes label Oct 30, 2023
@plypaul plypaul added Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment and removed cla:yes labels Oct 30, 2023
@plypaul plypaul temporarily deployed to DW_INTEGRATION_TESTS October 30, 2023 21:04 — with GitHub Actions Inactive
@plypaul plypaul temporarily deployed to DW_INTEGRATION_TESTS October 30, 2023 21:04 — with GitHub Actions Inactive
@plypaul plypaul temporarily deployed to DW_INTEGRATION_TESTS October 30, 2023 21:04 — with GitHub Actions Inactive
@plypaul plypaul temporarily deployed to DW_INTEGRATION_TESTS October 30, 2023 21:04 — with GitHub Actions Inactive
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Oct 30, 2023
@plypaul plypaul marked this pull request as ready for review October 30, 2023 21:25
courtneyholcomb
courtneyholcomb approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@courtneyholcomb courtneyholcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@plypaul plypaul merged commit 5b6c138 into main Oct 30, 2023
50 checks passed
@plypaul plypaul deleted the plypaul--61--remove-sql-engine-label-on-completion branch October 30, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@courtneyholcomb courtneyholcomb courtneyholcomb approved these changes

@tlento tlento Awaiting requested review from tlento

Assignees
No one assigned
Labels
Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plypaul @courtneyholcomb