Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

game_lineups not updated anymore #286

Closed
rakete1 opened this issue Mar 20, 2024 · 7 comments · Fixed by #287
Closed

game_lineups not updated anymore #286

rakete1 opened this issue Mar 20, 2024 · 7 comments · Fixed by #287
Assignees
Labels
bug Something isn't working dataset

Comments

@rakete1
Copy link

rakete1 commented Mar 20, 2024

Hi! Thank you for the great data set. What a clean work!!
However I might found an issue with the "game_lineups". The latest game_id is '4080529' which is a game from May 2023.
I expected to find the recent lineups in this file as well.
Best Regards
Ralph

@dcaribou
Copy link
Owner

dcaribou commented Apr 6, 2024

Re-opened in #290.

@Kokolaie
Copy link

Congratulations dcaribou for your work.
I started scraping tennis datas. I start having some significative amountof it for atp sets.

regarding your file, i may be wrong but i can't find some games in the game_lineups.
for example game_id:2244385 can't be found in game_lineups.

Sorry if my remark is already treated or meaningless i'm just a newbee trying to improve my skills in scraping and datasets.

@dcaribou
Copy link
Owner

It seem like that game's (2244385) lineup should be there, you are right @Kokolaie.
I can't tell why it isn't though. Most likely the last time lineups where scraped the lineups where not there, but I can't tell for sure.

The lineups scraper is broken atm, so unfortunately i can't be refreshed until this is resolved dcaribou/transfermarkt-scraper#88.

@Kokolaie
Copy link

Kokolaie commented May 11, 2024 via email

@dcaribou
Copy link
Owner

I have an extra question: why the club values are missing?

Which club values?

@Kokolaie
Copy link

Kokolaie commented May 11, 2024

the "total market value" in clubs.csv
Or to calculate it may be we justahave to add all players values?

@dcaribou
Copy link
Owner

the "total market value" in clubs.csv
Or to calculate it may be we justahave to add all players values?

Since this is unrelated to this issue, let's move this question somewhere else.
Please, check this discussion and that is not clarifying enough let's follow up there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dataset
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants