Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors changed issue #22

Open
lacherogwu opened this issue Jul 10, 2022 · 6 comments
Open

Colors changed issue #22

lacherogwu opened this issue Jul 10, 2022 · 6 comments

Comments

@lacherogwu
Copy link

Hey, The v2 made colors changed drastically and it seems something went wrong there
I wrote the version number at the top of the image

Screen Shot 2022-07-10 at 11 11 17

Screen Shot 2022-07-10 at 11 09 42

Screen Shot 2022-07-10 at 11 13 16

Thanks!

@dcasella
Copy link
Owner

Hi, could you send me the code snippets?
Thanks

@lacherogwu
Copy link
Author

lacherogwu commented Jul 12, 2022

import mongoose from 'mongoose';

const schema = new mongoose.Schema({
	name: {
		type: String,
		required: true,
	},
});


const model  = mongoose.model('test', schema)

export default model

@dcasella
Copy link
Owner

I can see that most of the other color themes I tried "get it wrong", since it's actually VS Code that makes up the semantic token type: it assigns "class" to type, address and liveChatGroupId, which makes absolutely no sense.

image

I'll see what I can do, but the source of the problem is VS Code.

@lacherogwu
Copy link
Author

I see, thanks for the information, btw what color theme do you use?
Because I see it look different than my picture and also const model is being colored in my code and in yours it doesn't

@dcasella
Copy link
Owner

The color theme in the screenshot is Dark+, the one which VS Code uses by default.
That was just to show that other color themes, even built-in ones, have trouble with the coloring: see address and String, both being green.

@lacherogwu
Copy link
Author

I understand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants