Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise "Disabled" flag on items and heroes #63

Open
hassayag opened this issue Oct 3, 2024 · 5 comments
Open

Standardise "Disabled" flag on items and heroes #63

hassayag opened this issue Oct 3, 2024 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@hassayag
Copy link
Member

hassayag commented Oct 3, 2024

There is use of Disabled and IsDisabled across hero and item data. Let's stick with just Disabled to keep it consistent

@hassayag hassayag added enhancement New feature or request good first issue Good for newcomers labels Oct 3, 2024
@hassayag hassayag changed the title Standardise "Disabled" flag on items and heroes feature/Standardise "Disabled" flag on items and heroes Oct 3, 2024
@hassayag hassayag changed the title feature/Standardise "Disabled" flag on items and heroes Standardise "Disabled" flag on items and heroes Oct 3, 2024
@kiara-abbey
Copy link

Hi, I'm a college student in an open-source software course. I can work on this!!! Would i just be editing the json files?

@hassayag
Copy link
Member Author

hassayag commented Oct 3, 2024

Hey! All json files in output-data/json are generated from the source code and are not editted manually.

We currently have two disabled flags, one for items, one for heroes. If you have a look around their parsers in here, you will see they each use a different name for their disabled flag.

When you have completed that, you will need to run the parser locally, which should then show changes in some of the output-data files.

Just be sure to go through the README first to get setup if you haven't already. Hope that helps!

@kiara-abbey
Copy link

This super helps! :) Thanks so much.

@B13rg
Copy link
Contributor

B13rg commented Oct 14, 2024

Related pr: #49

@hassayag
Copy link
Member Author

hassayag commented Nov 6, 2024

@kiara-abbey is this still with you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants