-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardise "Disabled" flag on items and heroes #63
Comments
Hi, I'm a college student in an open-source software course. I can work on this!!! Would i just be editing the json files? |
Hey! All json files in We currently have two disabled flags, one for items, one for heroes. If you have a look around their parsers in here, you will see they each use a different name for their disabled flag. When you have completed that, you will need to run the parser locally, which should then show changes in some of the Just be sure to go through the README first to get setup if you haven't already. Hope that helps! |
This super helps! :) Thanks so much. |
Related pr: #49 |
@kiara-abbey is this still with you? |
There is use of
Disabled
andIsDisabled
across hero and item data. Let's stick with justDisabled
to keep it consistentThe text was updated successfully, but these errors were encountered: