Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve commit messages to deadlock-data repo #91

Open
hassayag opened this issue Oct 27, 2024 · 2 comments
Open

Improve commit messages to deadlock-data repo #91

hassayag opened this issue Oct 27, 2024 · 2 comments
Labels
infra Codebase infrastructure, deployment, and CI changes

Comments

@hassayag
Copy link
Member

hassayag commented Oct 27, 2024

Current commit messages are just a generic "reparsed data". For PRs this is fine, but the commit history needs something for each case:

push - MERGE [v0.2.1-5555] - deadlock-wiki/deadbot@1234567 , where we have the version, build num, and commit hash referencing the one on deadbot
workflow-dispatch - DISPATCH [v0.2.0rev5-5555] - deadbot
pull-request - PR - deadlock-wiki/deadbot#88

To support this, we would also need some logic to increment the version

@hassayag hassayag added the infra Codebase infrastructure, deployment, and CI changes label Oct 27, 2024
@B13rg
Copy link
Contributor

B13rg commented Oct 28, 2024

For the increment version logic, is it the version of the gamefiles or the version of deadbot?

If it's the deadbot tagged version, parse it out from the pyproject.toml file?

Separate from this, it might be nice to have some deadbot release automation, unless we want to just have a "rolling release" and just run whatever's in the master branch

@hassayag
Copy link
Member Author

For the increment version logic, is it the version of the gamefiles or the version of deadbot?

Both, in the example v0.2.1 is the deadbot version, and 5555 is the build number you find inside steam.inf

If it's the deadbot tagged version, parse it out from the pyproject.toml file?

Yep! Would need some auto increment system. Eg. merge into develop increments the revision ("rev"), and merge into master will be a manual increment depending on whether its a match, major, or breaking change. Could try semantic commit messaging to handle that though

Separate from this, it might be nice to have some deadbot release automation, unless we want to just have a "rolling release" and just run whatever's in the master branch

I'd love more detail on this. At the moment there is no release system, but in my head it will be a case of saying every few weeks "oh develop looks good and stable, lets merge it into master". But I'm willing to explore other things, since the wiki moves very fast at this current stage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Codebase infrastructure, deployment, and CI changes
Projects
None yet
Development

No branches or pull requests

2 participants