Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown clip download fails if website does not have a 'title' tag #310

Open
WetHat opened this issue Mar 28, 2024 · 1 comment
Open

Markdown clip download fails if website does not have a 'title' tag #310

WetHat opened this issue Mar 28, 2024 · 1 comment

Comments

@WetHat
Copy link

WetHat commented Mar 28, 2024

Found in: https://www.developmentsimplyput.com/post/strategy-design-pattern-in-net-c

Despite a missing <title> tag the browser displays a reasonable title. However, the website cannot be clipped because pageTitle is empty. The extension silently fails to download anything. The solution appears to be to make sure the DOM string passed into getArticleFromDom (background.js) contains a <title> tag.

@evle-zzz
Copy link

+1 for that
Got similar behavior when tried to save some txt files which, obviously has neither {title} nor {pageTitle}.
There are two separate issues for that:

  1. If resulting filename is empty, there should be visual indication of an error, not just silent "do nothing" behaviour. Currently it's extremely easy to miss the fact that page is not actually saved.
  2. It would be nice to have some syntax for fallback or conditions. For example, I would like extension to try {title}, {pageTitle}, {baseURI} in this order to create a file name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants