Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the cookies SSO authentication flow #193

Open
orlando opened this issue Dec 10, 2019 · 0 comments
Open

Use the cookies SSO authentication flow #193

orlando opened this issue Dec 10, 2019 · 0 comments
Assignees
@orlando
Labels
enhancement New feature or request

Comments

@orlando
Copy link
Contributor

orlando commented Dec 10, 2019 •
edited
Loading

What: Use the cookies SSO authentication flow

Why: We implemented a new shared cookie that has the session for the current user. We want to use this instead of the current SSO flow implemented with the original Discourse SSO Provider.

With the current implementation, there's an issue with the session going out of sync. With the cookies based one, this issue should be resolved.

How:

  • Change the session code to read from the Discourse shared cookie.
  • Remove the code related to the original Discourse SSO implementation
  • Make sure session out of sync errors are fixed after this change
@orlando orlando added the enhancement New feature or request label Dec 10, 2019
@orlando orlando self-assigned this Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orlando orlando

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orlando