Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use specified avatar_url in git-gateway backend (1 line fix I think) #7246

Closed
loteoo opened this issue Jul 5, 2024 · 1 comment · Fixed by #7247
Closed

Use specified avatar_url in git-gateway backend (1 line fix I think) #7246

loteoo opened this issue Jul 5, 2024 · 1 comment · Fixed by #7247
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@loteoo
Copy link
Contributor

loteoo commented Jul 5, 2024

The git-gateway backend doesn't seem to pass the avatar_url field to the user object. A simple fix seems possible.

The avatar_url is received here: https://github.com/decaporg/decap-cms/blob/main/packages/decap-cms-backend-git-gateway/src/implementation.ts#L333

But then the returned object gets rid of it for no reason:
https://github.com/decaporg/decap-cms/blob/main/packages/decap-cms-backend-git-gateway/src/implementation.ts#L365

Describe the solution you'd like
It looks like simply adding avatar_url: userData.avatar_url in that object would fix the issue.

Possibly, I think the type here would also need it an update to add the avatar_url field: https://github.com/decaporg/decap-cms/blob/main/packages/decap-cms-lib-util/src/implementation.ts#L89

Thanks!

@loteoo loteoo added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jul 5, 2024
@loteoo
Copy link
Contributor Author

loteoo commented Jul 5, 2024

Made this PR: #7247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant