Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment bls_test and internal folder #517

Merged
merged 7 commits into from
May 15, 2024
Merged

Conversation

Robingoumaz
Copy link
Contributor

Uncommenting sign/bls/bls_test.go and fixed issues arising.
Also moved test tools into an internal folder.

@Robingoumaz Robingoumaz self-assigned this May 14, 2024
@Robingoumaz Robingoumaz reopened this May 14, 2024
@Robingoumaz Robingoumaz changed the base branch from master to drandmerge May 14, 2024 12:02
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
10.3% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

Copy link
Contributor

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is CI failing here?

@AnomalRoil AnomalRoil merged commit 2736907 into drandmerge May 15, 2024
8 of 9 checks passed
@AnomalRoil AnomalRoil deleted the robin-fix-blstest branch May 15, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants