Nonce removal from vss/EncryptedDeal struct #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please retry analysis of this Pull-Request directly on SonarCloud |
matteosz
changed the title
|
CluEleSsUK
reviewed
May 23, 2024
| @@ -408,7 +405,8 @@ func (v *Verifier) decryptDeal(e *EncryptedDeal) (*Deal, error) { | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| decrypted, err := gcm.Open(nil, e.Nonce, e.Cipher, v.hkdfContext) | |||
| nonce := make([]byte, gcm.NonceSize()) | |||
There was a problem hiding this comment.
is it intentional to pass in an empty slice here? it seems like it'd be better to remove it entirely (though this breaks the interface for other users potentially)
There was a problem hiding this comment.
I'm not sure I understood well your point but I'll try to answer anyway.
It's not possible to not pass the nonce, as it's required from the gcm interfact; additionally, if we were to pass nil instead that wouldn't work either, as it has to match the NonceSize(). Also, this is a v4 change, so it's okay to break our interfaces (the encrypted deal in this case).
AnomalRoil
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #379 by removing the nonce from the Encrypted Deal struct (as it's always 0)