Use the group-specific scalar type when hashing in BDN #553
Conversation
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
It's probably going to take a while for upstream to merge the changes so we're importing just the changed package (BDN) and the new package (Gnark) into this repo. That way we avoid forking the entire repo but can still import our changes. Any changes to these pacakges should be submitted as PRs to upstream _first_, then backported to this repo. Includes: - dedis/kyber#546 - dedis/kyber#551 - dedis/kyber#553
It's probably going to take a while for upstream to merge the changes so we're importing just the changed package (BDN) and the new package (Gnark) into this repo. That way we avoid forking the entire repo but can still import our changes. Any changes to these pacakges should be submitted as PRs to upstream _first_, then backported to this repo. Includes: - dedis/kyber#546 - dedis/kyber#551 - dedis/kyber#553
It's probably going to take a while for upstream to merge the changes so we're importing just the changed package (BDN) and the new package (Gnark) into this repo. That way we avoid forking the entire repo but can still import our changes. Any changes to these pacakges should be submitted as PRs to upstream _first_, then backported to this repo. Includes: - dedis/kyber#546 - dedis/kyber#551 - dedis/kyber#553
|
@Stebalien seems your PR didn't like your other PR getting squashed, sorry for that I somehow thought Github handled that automagically. Also it seems you might be touching some of the same bits and bobs as in #540 which removes insecure aggregation from the |
Stebalien
force-pushed
the
steb/correct-scaler-type
branch
from
3891ebb
to
5529dca
Compare
|
Rebased (although something is wrong with CI). This should only touch the bdn package so it shouldn't interfere too much with that PR, although it does change the |
I stumbled upon the group specific problem when removing the insecure part of BLS, I solved it pretty similarly though this fix is cleaner than mine. I can remove my fix from my pr and rebase on top of that one. |
The linter is complaining about commented code leftover, I guess that's why the rest of the pipeline got canceled |
Previously, `hashPointToR` would always use `mod.Int` but that only works with the Kilic backend. This change makes the BDN scheme work with all backends.
Stebalien
force-pushed
the
steb/correct-scaler-type
branch
from
5529dca
to
2886db7
Compare
|
Ah, that would make sense. Let's see if this works... |
|
Please retry analysis of this Pull-Request directly on SonarCloud |
|
Previously,
hashPointToRwould always usemod.Intbut that only works with the Kilic backend. This change makes the BDN scheme work with all backends.This PR is currently based on #546 as it touches masks. You can ignore everything but the last commit.