-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pruning rule in Pelt #306
Comments
Hi, sorry for the very late reply. We add
Therefore the rule Hope this helps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi! First of all, thank you for the great library - it has been a joy to use!
I have a question about the Pelt search algorithm. In the
Pelt
class, the_seg
method first computes the new additional cost for each chosen breakpoint and admissible partition before that. This is done at line 71:tmp_partition.update({(t, bkp): self.cost.error(t, bkp) + pen})
But then, when pruning non-optimal partitions, at lines 77-81
the condition (
if
...) in the list comprehension adds a new penalty termpen
tosum(partitions[bkp].values()
. I am struggling to understand, since the algorithm you describe on p.21 of the paper does not add this second penalty term.Is this a mistake or am I misunderstanding something? I'd be grateful for your help.
The text was updated successfully, but these errors were encountered: