From 8c1c65f1dfcfabcf8f501227e53f6c120e841c70 Mon Sep 17 00:00:00 2001 From: alexpeters1208 Date: Thu, 22 Aug 2024 10:47:54 -0500 Subject: [PATCH] Delegate blink checking and return values to Java impl --- py/server/deephaven/table.py | 11 ++++------- py/server/tests/test_table.py | 3 --- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/py/server/deephaven/table.py b/py/server/deephaven/table.py index a5b2c8bbced..1938af5dcf7 100644 --- a/py/server/deephaven/table.py +++ b/py/server/deephaven/table.py @@ -818,13 +818,10 @@ def flatten(self) -> Table: def remove_blink(self) -> Table: """Returns a new version of this table without specialized blink table aggregation semantics.""" - if self.is_blink: - try: - return Table(j_table=self.j_table.removeBlink()) - except Exception as e: - raise DHError(e, "failed to remove blink table semantics.") from e - else: - raise RuntimeError("Table is not a blink table, so blink table semantics cannot be removed.") + try: + return Table(j_table=self.j_table.removeBlink()) + except Exception as e: + raise DHError(e, "failed to remove blink table semantics.") from e def snapshot(self) -> Table: """Returns a static snapshot table. diff --git a/py/server/tests/test_table.py b/py/server/tests/test_table.py index 4b321fb6646..b37b89c8c14 100644 --- a/py/server/tests/test_table.py +++ b/py/server/tests/test_table.py @@ -936,9 +936,6 @@ def test_remove_blink(self): self.assertEqual(t_blink.is_blink, True) self.assertEqual(t_no_blink.is_blink, False) - with self.assertRaises(RuntimeError): - t_no_blink.remove_blink() - def test_grouped_column_as_arg(self): t1 = empty_table(100).update( ["id = i % 10", "Person = random() > 0.5 ? true : random() > 0.5 ? false : true"]).sort(