From dcbd44c13b91590edb5ebf15eed73e40e28aea05 Mon Sep 17 00:00:00 2001
From: Stan Brubaker <120737309+stanbrub@users.noreply.github.com>
Date: Wed, 13 Dec 2023 11:42:38 -0700
Subject: [PATCH] Docs CI V2 Rework For Old Rsync (#4941)

---
 .github/workflows/docs-ci-v2.yml | 50 ++++++++++++++++++++++----------
 1 file changed, 35 insertions(+), 15 deletions(-)

diff --git a/.github/workflows/docs-ci-v2.yml b/.github/workflows/docs-ci-v2.yml
index 66a480ee677..b6be35dd623 100644
--- a/.github/workflows/docs-ci-v2.yml
+++ b/.github/workflows/docs-ci-v2.yml
@@ -7,21 +7,36 @@ on:
     branches: [ 'main', 'release/v*' ]
 
 jobs:
+  makedirs:
+    runs-on: ubuntu-22.04
+    steps:
+      - name: Make Directories
+        run: |
+          mkdir -p tmp-deephaven-core-v2/${{ github.ref_name }}/
+          cd tmp-deephaven-core-v2/${{ github.ref_name }}/
+          mkdir -p javadoc pydoc client-api
+          cd client-api
+          mkdir -p javascript python cpp-examples cpp r
+          
+      - name: Deploy Directories
+        if: ${{ github.event_name == 'push' }}
+        uses: burnett01/rsync-deployments@5.2
+        with:
+          switches: -rlptDvz
+          path: tmp-deephaven-core-v2/
+          remote_path: deephaven-core-v2/
+          remote_host: ${{ secrets.DOCS_HOST }}
+          remote_port: ${{ secrets.DOCS_PORT }}
+          remote_user: ${{ secrets.DOCS_USER }}
+          remote_key: ${{ secrets.DEEPHAVEN_CORE_SSH_KEY }}
   symlink:
     if: ${{ github.event_name == 'push' && startsWith(github.ref, 'refs/heads/release/v') }}
     needs: [javadoc, typedoc, pydoc, cppdoc, rdoc]
     runs-on: ubuntu-22.04
-    concurrency:
-      group: symlink-${{ github.workflow }}-${{ github.ref }}
-      # We don't want to cancel in-progress jobs against main because that might leave the upload in a bad state.
-      cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
     steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
       - name: Make Symlinks
         run: |
-          mkdir -p tmp-deephaven-core-v2/symlinks;
+          mkdir -p tmp-deephaven-core-v2/symlinks
           cd tmp-deephaven-core-v2/symlinks
           ln -s ../${{ github.ref_name }} latest
           ln -s ../main next
@@ -37,6 +52,7 @@ jobs:
           remote_user: ${{ secrets.DOCS_USER }}
           remote_key: ${{ secrets.DEEPHAVEN_CORE_SSH_KEY }}
   javadoc:
+    needs: [makedirs]
     runs-on: ubuntu-22.04
     concurrency:
       group: javadoc-${{ github.workflow }}-${{ github.ref }}
@@ -90,7 +106,7 @@ jobs:
         if: ${{ github.event_name == 'push' }}
         uses: burnett01/rsync-deployments@5.2
         with:
-          switches: -rlptDvz --mkpath --delete
+          switches: -rlptDvz --delete
           path: combined-javadoc/build/docs/javadoc/
           remote_path: deephaven-core-v2/${{ github.ref_name }}/javadoc/
           remote_host: ${{ secrets.DOCS_HOST }}
@@ -99,6 +115,7 @@ jobs:
           remote_key: ${{ secrets.DEEPHAVEN_CORE_SSH_KEY }}
 
   typedoc:
+    needs: [makedirs]
     runs-on: ubuntu-22.04
     concurrency:
       group: typedoc-${{ github.workflow }}-${{ github.ref }}
@@ -147,7 +164,7 @@ jobs:
         if: ${{ github.event_name == 'push' }}
         uses: burnett01/rsync-deployments@5.2
         with:
-          switches: -rlptDvz --mkpath --delete
+          switches: -rlptDvz --delete
           path: web/client-api/types/build/documentation/
           remote_path: deephaven-core-v2/${{ github.ref_name }}/client-api/javascript/
           remote_host: ${{ secrets.DOCS_HOST }}
@@ -156,6 +173,7 @@ jobs:
           remote_key: ${{ secrets.DEEPHAVEN_CORE_SSH_KEY }}
 
   pydoc:
+    needs: [makedirs]
     runs-on: ubuntu-22.04
     concurrency:
       group: pydoc-${{ github.workflow }}-${{ github.ref }}
@@ -216,7 +234,7 @@ jobs:
         if: ${{ github.event_name == 'push' }}
         uses: burnett01/rsync-deployments@5.2
         with:
-          switches: -rlptDvz --mkpath --delete
+          switches: -rlptDvz --delete
           path: sphinx/build/docs/
           remote_path: deephaven-core-v2/${{ github.ref_name }}/pydoc/
           remote_host: ${{ secrets.DOCS_HOST }}
@@ -228,7 +246,7 @@ jobs:
         if: ${{ github.event_name == 'push' }}
         uses: burnett01/rsync-deployments@5.2
         with:
-          switches: -rlptDvz --mkpath --delete
+          switches: -rlptDvz --delete
           path: sphinx/build/pyclient-docs/
           remote_path: deephaven-core-v2/${{ github.ref_name }}/client-api/python/
           remote_host: ${{ secrets.DOCS_HOST }}
@@ -245,6 +263,7 @@ jobs:
           if-no-files-found: ignore
 
   cppdoc:
+    needs: [makedirs]
     runs-on: ubuntu-22.04
     concurrency:
       group: cppdoc-${{ github.workflow }}-${{ github.ref }}
@@ -298,7 +317,7 @@ jobs:
         if: ${{ github.event_name == 'push' }}
         uses: burnett01/rsync-deployments@5.2
         with:
-          switches: -rlptDvz --mkpath --delete
+          switches: -rlptDvz --delete
           path: sphinx/build/cppClientDocs/
           remote_path: deephaven-core-v2/${{ github.ref_name }}/client-api/cpp/
           remote_host: ${{ secrets.DOCS_HOST }}
@@ -310,7 +329,7 @@ jobs:
         if: ${{ github.event_name == 'push' }}
         uses: burnett01/rsync-deployments@5.2
         with:
-          switches: -rlptDvz --mkpath --delete
+          switches: -rlptDvz --delete
           path: sphinx/build/cppExamplesDocs/
           remote_path: deephaven-core-v2/${{ github.ref_name }}/client-api/cpp-examples/
           remote_host: ${{ secrets.DOCS_HOST }}
@@ -319,6 +338,7 @@ jobs:
           remote_key: ${{ secrets.DEEPHAVEN_CORE_SSH_KEY }}
 
   rdoc:
+    needs: [makedirs]
     runs-on: ubuntu-22.04
     concurrency:
       group: rdoc-${{ github.workflow }}-${{ github.ref }}
@@ -365,7 +385,7 @@ jobs:
         if: ${{ github.event_name == 'push' }}
         uses: burnett01/rsync-deployments@5.2
         with:
-          switches: -rlptDvz --mkpath --delete
+          switches: -rlptDvz --delete
           path: R/rdeephaven/docs/
           remote_path: deephaven-core-v2/${{ github.ref_name }}/client-api/r/
           remote_host: ${{ secrets.DOCS_HOST }}