Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS API doesn't handle redirected modifies correctly #6084

Open
niloc132 opened this issue Sep 19, 2024 · 1 comment · May be fixed by #6085
Open

JS API doesn't handle redirected modifies correctly #6084

niloc132 opened this issue Sep 19, 2024 · 1 comment · May be fixed by #6085
Assignees
@niloc132
Labels
barrage bug Something isn't working jsapi release blocker A bug/behavior that puts is below the "good enough" threshold to release. triage
Milestone
0.37.0

Comments

@niloc132
Copy link
Member

niloc132 commented Sep 19, 2024 •
edited
Loading

  1. Run the following groovy sample in the web IDE 
    tt=timeTable("PT1s")
lastTen=tt.tail(10)
inc = tt.whereIn(lastTen, "Timestamp")
exc = tt.whereNotIn(lastTen, "Timestamp")
j=tt.naturalJoin(inc, "Timestamp", "Inc=Timestamp").naturalJoin(exc, "Timestamp", "Exc=Timestamp")
pl=new io.deephaven.engine.util.PrintListener("Joined", j.tail(12), 12)
  2. Scroll to the bottom in the UI

Expected: the table in the UI should match the contents printed in the console - the last 10 rows should have values in the Inc column, and above that there should be values in the Exc column.

Actual: The 11th from the bottom row is not updating in some cases, instead it appears that only appends are happening.

Viewport.Bug.mov
@niloc132 niloc132 added bug Something isn't working jsapi barrage triage release blocker A bug/behavior that puts is below the "good enough" threshold to release. labels Sep 19, 2024
@niloc132 niloc132 added this to the 0.37.0 milestone Sep 19, 2024
@niloc132 niloc132 self-assigned this Sep 19, 2024
niloc132 added a commit to niloc132/deephaven-core that referenced this issue Sep 19, 2024
@niloc132
fix: JS should modify data in redirected space, not key space
c77e625 
Fixes deephaven#6084
@niloc132
Copy link
Member Author

Regression introduced by #5890.

@niloc132 niloc132 linked a pull request Sep 19, 2024 that will close this issue
Open
niloc132 added a commit to niloc132/deephaven-core that referenced this issue Sep 19, 2024
@niloc132
fix: JS should modify data in redirected space, not key space
ae460a2 
Fixes deephaven#6084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloc132 niloc132

Labels
barrage bug Something isn't working jsapi release blocker A bug/behavior that puts is below the "good enough" threshold to release. triage
Projects
None yet
Milestone
0.37.0
Development

Successfully merging a pull request may close this issue.

fix: JS should modify data in redirected space, not key space niloc132/deephaven-core
1 participant
@niloc132