Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup tree marker arrow color doesn't change based on background color #1134

Open
dsmmcken opened this issue Mar 6, 2023 · 1 comment
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dsmmcken
Copy link
Contributor

dsmmcken commented Mar 6, 2023

Color should treeMarkerColor be changed based on background color, see attached image for low contrast, non-visible colors:
image

We could rely on the engine for the foreground color and modify it with opacity for regular and hover states, or set a separate color and do an isDark check based on the color from the engine. Has to be checked per row.

Sample query:

simple_ticking = time_table("00:00:01").update([
        "MyString=new String(`a`+i)",
        "MyInt=new Integer(i)",
        "MyLong=new Long(i)",
        "MyDouble=new Double(i+i/10)",
        "MyFloat=new Float(i+i/10)",
        "MyBoolean=new Boolean(i%2==0)",
        "MyChar= new Character((char) ((i%26)+97))",
        "MyShort=new Short(Integer.toString(i%32767))",
        "MyByte= new java.lang.Byte(Integer.toString(i%127))"])\
        .rollup(aggs=agg_list, by=by_list)\
        .format_columns(["MyChar = MyLong > 2 ? `#C0C0C0` : `#000000`"])

Blocked by deephaven/deephaven-core#3487

Engine Version: 0.22.0
Web UI Version: 0.30.0
Java Version: 17.0.6
Barrage Version: 0.5.0

@dsmmcken dsmmcken added enhancement New feature or request triage Issue requires triage labels Mar 6, 2023
@vbabich vbabich added this to the March 2023 milestone Mar 8, 2023
@vbabich vbabich added good first issue Good for newcomers and removed triage Issue requires triage labels Mar 8, 2023
@mofojed mofojed modified the milestones: March 2023, April 2023 Apr 3, 2023
@mofojed mofojed modified the milestones: April 2023, June 2023 Jun 13, 2023
@mofojed mofojed modified the milestones: June 2023, July 2023 Aug 4, 2023
@mofojed mofojed modified the milestones: July 2023, August 2023 Aug 28, 2023
@mofojed mofojed modified the milestones: August 2023, September 2023 Sep 11, 2023
@mofojed mofojed modified the milestones: September 2023, November 2023 Nov 2, 2023
@mofojed mofojed modified the milestones: November 2023, January 2024 Jan 9, 2024
@mofojed mofojed modified the milestones: January 2024, February 2024 Feb 13, 2024
@mofojed mofojed modified the milestones: February 2024, March 2024 Mar 12, 2024
@mofojed mofojed modified the milestones: March 2024, April 2024 Apr 12, 2024
@mofojed mofojed removed this from the April 2024 milestone May 13, 2024
@mofojed
Copy link
Member

mofojed commented May 13, 2024

This won't be moving along until deephaven/deephaven-core#3487 is completed, removing from April milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants