Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call too many DescribeStacks API to check deploy statuses #727

Open
k2nr opened this issue May 27, 2022 · 0 comments
Open

Don't call too many DescribeStacks API to check deploy statuses #727

k2nr opened this issue May 27, 2022 · 0 comments

Comments

@k2nr
Copy link
Member

k2nr commented May 27, 2022

Before barcelona deploys a new version, it checks statuses of all stacks (for services)

barcelona/app/jobs/deploy_runner_job.rb

Line 46 in 1b94dbb

heritage.services.map { |s| !s.deployment_finished?(nil) }.any?

While it is necessary to check it, calling DescribeStacks for each service is unnecessary because DescribeStacks returns all stacks if StackName is not specified https://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_DescribeStacks.html

We can optimize that line so that barcelona calls DescribeStacks only once per deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@k2nr