Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify struct CNMF_results #52

Open
degleris1 opened this issue May 20, 2019 · 1 comment
Open

Modify struct CNMF_results #52

degleris1 opened this issue May 20, 2019 · 1 comment

Comments

@degleris1
Copy link
Owner

Several function take CNMF_results as an argument, including important visualization tools.

However, if the user has a W and H from some other algorithm, they must put in the CNMF_results struct first and set a number of parameters to nothing. I propose we either (a) overload these functions with their corresponding non-struct arguments or (b) change the last fields of the struct (l1_reg, l2_reg, ...) to a single field model_params which contains a dictionary.

@bantin
Copy link
Collaborator

bantin commented May 21, 2019

@degleris1 I think adding methods to the visualization function is a good way to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants