Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBSOLETE_BY does not prevent building #409

Open
xypron opened this issue Mar 26, 2024 · 1 comment
Open

OBSOLETE_BY does not prevent building #409

xypron opened this issue Mar 26, 2024 · 1 comment

Comments

@xypron
Copy link

xypron commented Mar 26, 2024

The OBSOLETE_BY value is used in do_install() to prevent installing a module that is no longer needed or supported since the specified kernel version.

But the module is still being built.

It does not make much sense to build a module that will never be installed:

  • The source code may not be compatible to the new kernel source due to changed kernel APIs.
  • Building may take a considerable time.

We should not build modules for kernels which match the OBSOLETE_BY version.

@evelikov
Copy link
Collaborator

The last related change I can see is from 2020 94a08e6 which was reverted shortly after - see 885f827.

Sadly neither the revert nor the PR #126 mention why - @GoPerry do you have any recollections?

@xypron do you have a git repo/project with an example of using OBSOLETE_BY? Can we interest you in writing a test and/or fix :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants