[BUG] delta-iceberg JAR does not shade caffeine dependencies

[tom-s-powell]

Bug

Which Delta project/connector is this regarding?

• Spark
• Standalone
• Flink
• Kernel
• Other (fill in here)

Describe the problem

https://mvnrepository.com/artifact/io.delta/delta-iceberg_2.13/3.2.0 does not shade https://github.com/ben-manes/caffeine. Other dependencies are shaded.

Steps to reproduce

jar tf delta-iceberg_2.13-3.2.0.jar

Observed results

META-INF/
META-INF/MANIFEST.MF
LICENSE_iceberg-api-8c7995e
LICENSE_iceberg-bundled-guava-8c7995e
LICENSE_iceberg-common-8c7995e
LICENSE_iceberg-core-8c7995e
LICENSE_iceberg-data-8c7995e
LICENSE_iceberg-hive-metastore-8c7995e
LICENSE_iceberg-parquet-8c7995e
META-INF/LICENSE_caffeine-2.9.3
META-INF/jandex.idx
META-INF/services/
META-INF/services/org.apache.spark.sql.sources.DataSourceRegister
NOTICE.txt_delta-iceberg_2.13-3.2.0
NOTICE_iceberg-api-8c7995e
NOTICE_iceberg-bundled-guava-8c7995e
NOTICE_iceberg-common-8c7995e
NOTICE_iceberg-core-8c7995e
NOTICE_iceberg-data-8c7995e
NOTICE_iceberg-hive-metastore-8c7995e
NOTICE_iceberg-parquet-8c7995e
com/
com/github/
com/github/benmanes/
com/github/benmanes/caffeine/
com/github/benmanes/caffeine/SCQHeader$HeadAndTailRef.class
com/github/benmanes/caffeine/SCQHeader$HeadRef.class
com/github/benmanes/caffeine/SCQHeader$PadHead.class
com/github/benmanes/caffeine/SCQHeader$PadHeadAndTail.class
com/github/benmanes/caffeine/SCQHeader.class
com/github/benmanes/caffeine/SingleConsumerQueue$1.class
com/github/benmanes/caffeine/SingleConsumerQueue$LinearizableNode.class
com/github/benmanes/caffeine/SingleConsumerQueue$Node.class
com/github/benmanes/caffeine/SingleConsumerQueue$SerializationProxy.class
com/github/benmanes/caffeine/SingleConsumerQueue.class
com/github/benmanes/caffeine/base/
com/github/benmanes/caffeine/base/UnsafeAccess.class
com/github/benmanes/caffeine/cache/
com/github/benmanes/caffeine/cache/AbstractLinkedDeque$1.class
...
shadedForDelta/org/apache/iceberg/relocated/com/google/common/base/CharMatcher$SingleWidth.class
shadedForDelta/org/apache/iceberg/relocated/com/google/common/base/CharMatcher$Whitespace.class
shadedForDelta/org/apache/iceberg/relocated/com/google/common/base/CharMatcher.class
shadedForDelta/org/apache/iceberg/relocated/com/google/common/base/Charsets.class
...

Expected results

I'd expect all dependencies to be shaded consistently to avoid potential classpath conflicts for consumers.

Further details

N/A

Environment information

• Delta Lake version:
• Spark version: 3.2.0
• Scala version: 2.12

Willingness to contribute

The Delta Lake Community encourages bug fix contributions. Would you or another member of your organization be willing to contribute a fix for this bug to the Delta Lake code base?

• Yes. I can contribute a fix for this bug independently.
• Yes. I would be willing to contribute a fix for this bug with guidance from the Delta Lake community.
• No. I cannot contribute a bug fix at this time.