Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Matching Engine]: Update for reserve stocks #289

Open
nimishagarwal76 opened this issue Dec 18, 2019 · 0 comments
Open

[Matching Engine]: Update for reserve stocks #289

nimishagarwal76 opened this issue Dec 18, 2019 · 0 comments

Comments

@nimishagarwal76
Copy link
Collaborator

Previously, in case of PerformOrderFillTransaction, askTransaction would have negative stockTradeQty which would get sent to the datastream. Now, it's 0 as user doesn't actually have to lose stocks anymore.
HACK:
Re-setting the object just before sending back the tranasction ensures that the rest of the matching engine / order book code functions without requiring changes.

Need to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant