From a91a30e1105006c898bd94fec39d487be14caa34 Mon Sep 17 00:00:00 2001 From: Daniel Levin Date: Wed, 28 Aug 2024 00:28:19 -0500 Subject: [PATCH] Add 'dupbuild' as deprecated warning Fixup after 8f47d5aa33c6c303a71093be2eac02672dfb2966 Since v1.12 ninja breaks compatibility with existing generators, particularly bob build system, which always invokes ninja with -w dupbuild=err See: https://github.com/ARM-software/bob-build/blob/master/bob.bash This patch should also be applied to the 'release' branch. --- src/ninja.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/ninja.cc b/src/ninja.cc index 2902359f15..8306147c20 100644 --- a/src/ninja.cc +++ b/src/ninja.cc @@ -1230,6 +1230,10 @@ bool WarningEnable(const string& name, Options* options) { } else if (name == "phonycycle=warn") { options->phony_cycle_should_err = false; return true; + } else if (name == "dupbuild=err" || + name == "dupbuild=warn") { + Warning("deprecated warning 'dupbuild'"); + return true; } else if (name == "depfilemulti=err" || name == "depfilemulti=warn") { Warning("deprecated warning 'depfilemulti'");