make it possible to remove the root node #11
Conversation
|
@derekparker any chance this is going to be merged ? |
|
@derekparker - can we merge this PR, please? |
| @@ -89,22 +89,33 @@ func (t *Trie) HasKeysWithPrefix(key string) bool { | |||
|
|
|||
| // Removes a key from the trie, ensuring that | |||
| // all bitmasks up to root are appropriately recalculated. | |||
| func (t *Trie) Remove(key string) { | |||
| func (t *Trie) Remove(key string) bool { | |||
There was a problem hiding this comment.
I don't think we should change the function signature here as it would break consumers of the library. Any breaking change would require a major version update.
| t.size-- | ||
| for n := node.Parent(); n != nil; n = n.Parent() { | ||
| i++ | ||
|
|
||
| if n == t.root { | ||
| t.root = &Node{children: make(map[rune]*Node)} |
There was a problem hiding this comment.
We can break from the loop immediately following this assignment.
| t.Errorf("Expected 0 keys got %d", len(keys)) | ||
| } | ||
|
|
||
| //try to write some data after the trie was purged |
There was a problem hiding this comment.
nit: space after // and uppercase first word of comment.
|
I think the best path forward to merge this is for me to take over the patch and credit the original author somehow, unless @HeavyHorst is still willing to update this patch. Sorry for the extreme delay in reviewing this change. |
|
Feel free to take over the patch :) |
this should fix issue #4
This change is