Fix 2D Gaussian fitting and related title formatting of qlook #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astropenguin
changed the title
astropenguin
requested changes
Aug 9, 2024
There was a problem hiding this comment.
Thank you for the quick fixing! I would like to propose the following updates.
GaussFit_cont_flag: The term "flag" is ambiguous in this context. I think more explicit name (e.g.is_gaussfit_successful) would be nice.- try-except block: Newer codes (
data[np.isnan(data)] = 0) seem to be overwritten by older ones (data[data != data] = 0.0). - Plot title: When Gaussian fit is failed, could you show peak-based pointing offset (like L253, L476 of v2024.8.0)?
astropenguin
added
feature
astropenguin
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #197.