You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The function spectrometer_sensitivity() requires the input eta_circuit, which has a default value of 0.32. In simulator.py, it is described as follows:
The loss at chip temperature, *in the circuit.*. Units: None.
This, however, may confuse the user, as eta_circuit is more formally defined as the peak transmission times a correction factor of pi/4, due to the filter being shaped as a Lorentzian. This is in line with how eta_circuit is defined in filter.py:
Average transmission over the FWHM. Equal to pi/4 times the peak transmission
To clarify its definition, I would like to suggest to add the description used in filter.py to the one in simulator.py, as users might use the latter as the reference
The text was updated successfully, but these errors were encountered:
The function
spectrometer_sensitivity()
requires the inputeta_circuit
, which has a default value of 0.32. In simulator.py, it is described as follows:The loss at chip temperature, *in the circuit.*. Units: None.
This, however, may confuse the user, as eta_circuit is more formally defined as the peak transmission times a correction factor of pi/4, due to the filter being shaped as a Lorentzian. This is in line with how
eta_circuit
is defined in filter.py:Average transmission over the FWHM. Equal to pi/4 times the peak transmission
To clarify its definition, I would like to suggest to add the description used in filter.py to the one in simulator.py, as users might use the latter as the reference
The text was updated successfully, but these errors were encountered: