Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description of eta_circuit and the factor of pi/4 #82

Open
MatthijsRoos opened this issue Jun 21, 2023 · 0 comments
Open

Description of eta_circuit and the factor of pi/4 #82

MatthijsRoos opened this issue Jun 21, 2023 · 0 comments

Comments

@MatthijsRoos
Copy link

The function spectrometer_sensitivity() requires the input eta_circuit, which has a default value of 0.32. In simulator.py, it is described as follows:

The loss at chip temperature, *in the circuit.*. Units: None.

This, however, may confuse the user, as eta_circuit is more formally defined as the peak transmission times a correction factor of pi/4, due to the filter being shaped as a Lorentzian. This is in line with how eta_circuit is defined in filter.py:

Average transmission over the FWHM. Equal to pi/4 times the peak transmission

To clarify its definition, I would like to suggest to add the description used in filter.py to the one in simulator.py, as users might use the latter as the reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant