Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should is_skippable get a better name? #182

Open
jank324 opened this issue Jun 18, 2024 · 0 comments
Open

Should is_skippable get a better name? #182

jank324 opened this issue Jun 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jank324
Copy link
Member

jank324 commented Jun 18, 2024

We discussed that the name is a bit confusing. Please make proposals!

I think one idea was is_reducable because it is used to determine if an element is eligible for transfer map reduction. There was also a proposal along the lines of torch.Tensor.requires_grad.

Somewhat related to #43.

@jank324 jank324 added the enhancement New feature or request label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant