Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsused instances and imports of UniqueNameGenerator #190

Open
Hespe opened this issue Jun 19, 2024 · 1 comment
Open

Unsused instances and imports of UniqueNameGenerator #190

Hespe opened this issue Jun 19, 2024 · 1 comment

Comments

@Hespe
Copy link
Member

Hespe commented Jun 19, 2024

In many element classes, there are unused instances and imports of UniqueNameGenerator, e.g. in

generate_unique_name = UniqueNameGenerator(prefix="unnamed_element")
since the names are generated in the superclass Element.

The unused instances could either be removed or changed to a more specific prefix and employed for overwriting the generic unique name from Element.

@jank324
Copy link
Member

jank324 commented Jun 20, 2024

Good point. I thought about class-specific prefixes at some point in the past, but then didn't do it for some reason. I don't remember why. I tried to find an issue where I may have written this down, but didn't find one.

Right now I'm inclined to vote for removing the unsung instances. It's the simpler solution, but I don't know if it's the better one.

@cr-xu, do you have thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants