-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsused instances and imports of UniqueNameGenerator #190
Comments
Good point. I thought about class-specific prefixes at some point in the past, but then didn't do it for some reason. I don't remember why. I tried to find an issue where I may have written this down, but didn't find one. Right now I'm inclined to vote for removing the unsung instances. It's the simpler solution, but I don't know if it's the better one. @cr-xu, do you have thoughts on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In many element classes, there are unused instances and imports of
UniqueNameGenerator
, e.g. incheetah/cheetah/accelerator/dipole.py
Line 14 in a35fc03
Element
.The unused instances could either be removed or changed to a more specific prefix and employed for overwriting the generic unique name from
Element
.The text was updated successfully, but these errors were encountered: