-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't test for C++version, test for features #1
Comments
Completely agree with your comment. I also encountered this problem on Linux. Actually this guard was made only from the reason of complication. However, we have another problem, how to keep track of these flexible settings when the library changed. |
About problem 'how to track' - yeah. If you don't used to tracking feature test macros and stuff, it is hard. But that thing make things way more portable. Bad things also can happen even if you a large company - google/googletest#3659 |
I found such a check in your code.
I think it's much better to check for library feature macros and compiler feature macros for what you exactly used.
I had a lot of problems in my past, checking for __cplusplus and then having issues in Linux, when compiler and STL version are not in sync (imagine using clang 10 with libstdc++6 for example).
The text was updated successfully, but these errors were encountered: