Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account for mountSources when calculating per-workspace PVC size #1253

Closed
wants to merge 3 commits into from
Closed

fix: account for mountSources when calculating per-workspace PVC size #1253

wants to merge 3 commits into from

Commits on Apr 17, 2024

  1. chore: Document per-workspace PVC size calculation function 

    Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
    @AObuchow
    AObuchow committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    6ddb177 View commit details
    Browse the repository at this point in the history

  2. chore: add test for mountSources PVC size calculation 

    Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
    @AObuchow
    AObuchow committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    b497c14 View commit details
    Browse the repository at this point in the history

  3. fix: Use at least minimum PVC size when mountSources used 

    Fix devfile#1239

This commit fixes an edge case where a devworkspace that has no volume components,
but has a container component with mountSources enabled will request a PVC size of 0
when using the per-workspace storage strategy.

When mountSources are used, the devworkspace requires storage to store the project sources.
However, it is unknown how much storage is actually required for the project sources.
Thus, we treat container components with mountSources enabled as if they were volume components
with an unspecified size.

Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
    @AObuchow
    AObuchow committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    3eb15f5 View commit details
    Browse the repository at this point in the history