Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor exercise #3

Open
thgaskell opened this issue Dec 26, 2015 · 0 comments
Open

Refactor exercise #3

thgaskell opened this issue Dec 26, 2015 · 0 comments

Comments

@thgaskell
Copy link

I think that this exercise deserves a makeover. I think the mix of rounding errors, number parsing, and wordy descriptions take away from the intended nature of the exercise, which is using array iterator methods.

The exported json value also gets cached, and if it's modified via reassignment, it carries over to the next tests which produces some weird side effects when running with the mocha watch task.

In addition, testing the values of global variables is kind of clunky because the tests are just testing for a certain value, rather than if the code is doing the correct things. Exported functions could allow for variable cutoff points for filtering, tax values, and states to filter by.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant