Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate 'config.aws_region' option and add 'config.default_aws_region' option. #7

Open
3 tasks
simnalamburt opened this issue Nov 15, 2017 · 0 comments

Comments

@simnalamburt
Copy link
Contributor

simnalamburt commented Nov 15, 2017

config.aws_region overrides AWS_REGION environment variable, and changing config variables in ~/.ecl/config.rb is not ergonomically convenient. So many users just comment out the config.aws_region variable and use the use the AWS_REGION.

So let's add new configuration option named config.default_aws_region which does not overrides AWS_REGION environment variable, and deprecate config.aws_region option.

TODOs

  • Remove config.aws_region option from documentation and eclare config template.
  • Print a warning to the STDERR when config.aws_region variable is set by the user.
  • Implement new config.default_aws_region option and mention it on docs and config template file.

How do you think?

(Blocked by #9)

@simnalamburt simnalamburt self-assigned this Nov 15, 2017
@simnalamburt simnalamburt removed their assignment Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant