-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check links on build #54
Comments
I've tested the plugin with a hugo-netlify-starter fork: |
All I needed to do was install the plugin, and add the plugin info to the netlify.toml file. |
Not sure how the plugin works, but we could use a GitHub Action to check links. I'm pretty sure that either the plugin or a similar tool could validate links in the generated HTML. |
I think I'd rather use a GitHub action, the Netlify plugin seems pretty opaque. I'll do some research on the GitHub action and see if it's got a better developer experience. |
Added a Makefile command to check links The tool itself is pretty popular, probably we can just run this check on CI periodically. |
We should check that links in our site don't 404 when we do a PR.
If we agree, here is an option:
(it's listed on the plugins page https://app.netlify.com/teams/dex-8nqqgjy/plugins, but I don't want to try it w/o having a discussion first -- I'm not sure what licenses we want our tools to have, or indeed if this completely solves the issue of highlighting broken links)
I'm happy for other suggestions.
The text was updated successfully, but these errors were encountered: